Skip to content

Revert "test: don't assume broadcast traffic is unfiltered" #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2015
Merged

Revert "test: don't assume broadcast traffic is unfiltered" #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df3c4ca
Revert "test: don't assume broadcast traffic is unfiltered"
bnoordhuis Jan 8, 2015
7266b75
test: move broadcast/multicast test to internet/
bnoordhuis Jan 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...lel/test-dgram-broadcast-multi-process.js → ...net/test-dgram-broadcast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ var common = require('../common'),
assert = require('assert'),
dgram = require('dgram'),
util = require('util'),
networkInterfaces = require('os').networkInterfaces(),
Buffer = require('buffer').Buffer,
fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '255.255.255.255',
Expand All @@ -34,6 +35,19 @@ var common = require('../common'),
new Buffer('Fourth message to send')
];

// take the first non-internal interface as the address for binding
get_bindAddress: for (var name in networkInterfaces) {
var interfaces = networkInterfaces[name];
for(var i = 0; i < interfaces.length; i++) {
var localInterface = interfaces[i];
if (!localInterface.internal && localInterface.family === 'IPv4') {
var bindAddress = localInterface.address;
break get_bindAddress;
}
}
}
assert.ok(bindAddress);

if (process.argv[2] !== 'child') {
var workers = {},
listeners = 3,
Expand Down Expand Up @@ -150,7 +164,7 @@ if (process.argv[2] !== 'child') {

// bind the address explicitly for sending
// INADDR_BROADCAST to only one interface
sendSocket.bind(common.PORT, '127.0.0.1');
sendSocket.bind(common.PORT, bindAddress);
sendSocket.on('listening', function () {
sendSocket.setBroadcast(true);
});
Expand Down Expand Up @@ -197,7 +211,7 @@ if (process.argv[2] === 'child') {

listenSocket.on('message', function(buf, rinfo) {
// receive udp messages only sent from parent
if (rinfo.address !== '127.0.0.1') return;
if (rinfo.address !== bindAddress) return;

console.error('[CHILD] %s received %s from %j',
process.pid,
Expand Down