report: use libuv calls for OS and machine info #25900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Feb 2, 2019
gengjiawen
approved these changes
Feb 2, 2019
richardlau
reviewed
Feb 3, 2019
richardlau
approved these changes
Feb 4, 2019
PR-URL: nodejs#25900 Fixes: nodejs#25843 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 6, 2019
PR-URL: #25900 Fixes: #25843 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace platform specific code with libuv calls. Note that currently
uv_os_uname()doesn't report the full product name on Windows. There is an open PR to libuv that would add that information. I'm not sure if anyone feels strongly about this landing before that libuv update. It doesn't matter to me, but see #25843.Fixes: #25843
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes