src: add PrintLibuvHandleInformation debug helper #25905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is not only helpful for debugging crashes, but can also be used as an ad-hoc debugging statement.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Feb 3, 2019
bnoordhuis
reviewed
Feb 3, 2019
|
Yeah, sorry this didn’t compile/pass … actually running |
bnoordhuis
approved these changes
Feb 4, 2019
jasnell
approved these changes
Feb 5, 2019
addaleax
added
the
author ready
|
Landed in 46d9573 |
addaleax
added a commit
that referenced
this pull request
Feb 5, 2019
This function is not only helpful for debugging crashes, but can also be used as an ad-hoc debugging statement. PR-URL: #25905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 6, 2019
This function is not only helpful for debugging crashes, but can also be used as an ad-hoc debugging statement. PR-URL: #25905 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not only helpful for debugging crashes,
but can also be used as an ad-hoc debugging statement.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (probably)