Skip to content

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 4, 2019

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 4, 2019
@addaleax
Copy link
Member

addaleax commented Feb 4, 2019

This conflicts with #25896.

I also find it confusing: These are the same objects, so referring to them by the same name makes sense, right?

@gengjiawen
Copy link
Member Author

They are in the same function, so better with different name IMHO.

@gengjiawen gengjiawen force-pushed the feature/redability_node_trace_buffer branch from aff0acc to f25d583 Compare February 5, 2019 02:16
@gengjiawen gengjiawen force-pushed the feature/redability_node_trace_buffer branch from f25d583 to 6c18ed9 Compare February 5, 2019 02:19
@gengjiawen
Copy link
Member Author

Current there is three buffer in this method, give those different name will make it more readable
image

@gengjiawen
Copy link
Member Author

@addaleax give this another thought or leave it the old way ?

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

@gengjiawen Yeah, I’m still -1 on doing this. You can wait for others to chime in, if you want.

@gengjiawen gengjiawen closed this Feb 6, 2019
@gengjiawen gengjiawen deleted the feature/redability_node_trace_buffer branch February 6, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants