src: make watchdog async callback a lambda #25945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Feb 5, 2019
addaleax
approved these changes
Feb 5, 2019
cjihrig
approved these changes
Feb 5, 2019
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25684/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/25714/ |
gireeshpunathil
added
the
author ready
`Watchdog::Async` features only once for the async callback, so make it a lambda. PR-URL: nodejs#25945 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gireeshpunathil
force-pushed
the
lambda
branch
from
a181df3 to
7182aca
Compare
gireeshpunathil
removed
the
author ready
|
landed as 7182aca |
addaleax
pushed a commit
that referenced
this pull request
Feb 8, 2019
`Watchdog::Async` features only once for the async callback, so make it a lambda. PR-URL: #25945 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchdog::Asyncfeatures only once for the async callback, so make it a lambda.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes