doc: consolidate N-API material in Colalborator Guide #26094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate the N-API material in the Collaborator Guide to be succinct and direct.
|
@nodejs/n-api |
jasnell
approved these changes
Feb 14, 2019
Trott
added
the
author ready
bengl
approved these changes
Feb 16, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 16, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct and direct. PR-URL: nodejs#26094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]>
|
Landed in 5bb7764 |
addaleax
pushed a commit
that referenced
this pull request
Feb 17, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct and direct. PR-URL: #26094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct and direct. PR-URL: #26094 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes