src: remove cast for unsupported openssl #26305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x, and 10.x no longer support.
|
@sam-github sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
c++
jasnell
approved these changes
Feb 26, 2019
bnoordhuis
approved these changes
Feb 26, 2019
thefourtheye
approved these changes
Feb 26, 2019
cjihrig
approved these changes
Feb 26, 2019
|
Landed in 3f31c88 |
sam-github
added a commit
that referenced
this pull request
Feb 28, 2019
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x, and 10.x no longer support. PR-URL: #26305 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x, and 10.x no longer support. PR-URL: #26305 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.
To be clear, I mean don't support even when configured against an external openssl.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes