- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.5k
tools: bump lint-node-md-cli-rollup to version 2 #26441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | /CC @nodejs/linting | 
            
                  richardlau
  
            
            approved these changes
            
                
                  Mar 4, 2019 
                
            
            
          
          
            
                  Trott
  
            
            approved these changes
            
                
                  Mar 4, 2019 
                
            
            
          
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
            
                  cjihrig
  
            
            approved these changes
            
                
                  Mar 5, 2019 
                
            
            
          
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
            
                  watilde
  
            
            approved these changes
            
                
                  Mar 5, 2019 
                
            
            
          
          
| @refack this needs a rebase | 
PR-URL: nodejs#26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: nodejs#26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
| Linter CI test: https://ci.nodejs.org/job/node-test-linter/26155/ ✔️ | 
    
  BridgeAR 
      pushed a commit
      that referenced
      this pull request
    
      Mar 13, 2019 
    
    
      
  
    
      
    
  
PR-URL: #26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  BridgeAR 
      pushed a commit
      that referenced
      this pull request
    
      Mar 13, 2019 
    
    
      
  
    
      
    
  
PR-URL: #26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  BridgeAR 
      pushed a commit
      that referenced
      this pull request
    
      Mar 14, 2019 
    
    
      
  
    
      
    
  
PR-URL: #26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
    
  BridgeAR 
      pushed a commit
      that referenced
      this pull request
    
      Mar 14, 2019 
    
    
      
  
    
      
    
  
PR-URL: #26441 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Now with minification.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes