stream: reduce internal usage of public require of util #26698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ZYSzys
approved these changes
Mar 16, 2019
cjihrig
approved these changes
Mar 16, 2019
targos
approved these changes
Mar 16, 2019
richardlau
approved these changes
Mar 16, 2019
BridgeAR
approved these changes
Mar 17, 2019
BridgeAR
added
the
author ready
jasnell
approved these changes
Mar 17, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 21, 2019
PR-URL: nodejs#26698 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c97851d 🎉 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26698 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26698 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Why @nodejs/streams was not tagged on this one? I would have opposed this change landing. |
|
Yes, this should not have happened, see nodejs/readable-stream#416 (comment). I’ll open a revert PR for the streams parts. |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Sep 6, 2019
…util" This partially reverts commit c97851d. Streams code should ideally require on public APIs as much as possible, because it is exported as readable-stream. Refs: nodejs#26698 Refs: nodejs/readable-stream#416
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #26546
Reduce internal usage of public require of
utilin the scope of stream.make -j4 test(UNIX), orvcbuild test(Windows) passes