Skip to content

tls: remove usage of public require('util') #26747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tls: remove usage of public require('util') #26747

wants to merge 1 commit into from

Conversation

@dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 18, 2019

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
_tls_wrap: remove usage of public require('util')
956cbcd 
Remove the usage of public require('util'), as described in issue:
  nodejs#26546
@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Mar 18, 2019
sam-github
sam-github reviewed Mar 18, 2019
View reviewed changes
@dnlup dnlup mentioned this pull request Mar 20, 2019
Closed
@BridgeAR BridgeAR changed the title _tls_wrap: remove usage of public require('util') tls: remove usage of public require('util') Mar 22, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21752/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21801/

@BridgeAR
Copy link
Member

BridgeAR commented Mar 24, 2019

Landed in a1330af 🎉

@BridgeAR BridgeAR closed this Mar 24, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 24, 2019
@dnlup @BridgeAR
tls: remove usage of public require('util')
a1330af 
Remove the usage of public require('util'), as described in:
nodejs#26546

PR-URL: nodejs#26747
Refs: nodejs#26546
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dnlup dnlup deleted the util_tls_wrap branch January 10, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@sam-github sam-github sam-github left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dnlup @BridgeAR @sam-github @jasnell @addaleax @targos @nodejs-github-bot