Skip to content

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 19, 2019

Remove usage of public require('util').inspect,
require('util').formatWithOptions and require('util').types.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Remove usage of public `require('util').inspect` and 
`require('util').formatWithOptions`.

Refs: nodejs#26546
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Mar 19, 2019
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@BridgeAR
Copy link
Member

@BridgeAR
Copy link
Member

Landed in cf1b9d3 🎉

@BridgeAR BridgeAR closed this Mar 24, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 24, 2019
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: nodejs#26777
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Remove usage of public `require('util').inspect` and
`require('util').formatWithOptions`.

PR-URL: #26777
Refs: #26546
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@dnlup dnlup deleted the util_internal_console_constructor branch January 10, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants