Skip to content

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 23, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 23, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 23, 2019

👍 to fast track

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21831/

EDIT: CI was green.

@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2019
PR-URL: nodejs#26879
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants