src: elevate v8::Task namespace #26909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
targos
approved these changes
Mar 25, 2019
|
I've made other contributions doing the same, does anyone here has documentation about how C++ bindings works, how C++ API is connected with JS API's?, or if could anyone explain me that would be awesome! I'd love to do more "valuable" contributions in C++ |
cjihrig
approved these changes
Mar 25, 2019
BridgeAR
approved these changes
Mar 26, 2019
BridgeAR
added
the
author ready
|
Landed in a3cf96c |
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
PR-URL: #26909 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax is probably one of the best people to ask this. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
PR-URL: #26909 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
PR-URL: #26909 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
PR-URL: #26909 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes