async_hooks: minor cleanup and improvements #27034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup some code and make the emit hooks very slightly faster.
nodejs-github-bot
added
the
async_hooks
ZYSzys
approved these changes
Apr 1, 2019
BridgeAR
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 3, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 4, 2019
Cleanup some code and make the emit hooks very slightly faster. PR-URL: nodejs#27034 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 04355ef 🎉 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
Cleanup some code and make the emit hooks very slightly faster. PR-URL: #27034 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
Cleanup some code and make the emit hooks very slightly faster. PR-URL: #27034 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup some code and make the emit hooks very slightly faster.
CI: https://ci.nodejs.org/job/node-test-pull-request/22080/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes