src: enable non-nestable V8 platform tasks #27252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never execute tasks in a nested fashion, so enabling them should be as simple as forwarding tasks to the existing `Post*` methods.
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Apr 16, 2019
jasnell
approved these changes
Apr 16, 2019
addaleax
added
the
author ready
danbev
approved these changes
Apr 17, 2019
|
Landed in f9da3f0 |
addaleax
added a commit
that referenced
this pull request
Apr 18, 2019
We never execute tasks in a nested fashion, so enabling them should be as simple as forwarding tasks to the existing `Post*` methods. PR-URL: #27252 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Apr 23, 2019
addaleax
added
the
v8 platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never execute tasks in a nested fashion, so enabling them should
be as simple as forwarding tasks to the existing
Post*methods.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes