test: add mustCall to test-net-after-close test #27459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZYSzys
approved these changes
Apr 28, 2019
ZYSzys
added
the
code-and-learn
starkwang
approved these changes
Apr 28, 2019
yorkie
approved these changes
Apr 28, 2019
gireeshpunathil
approved these changes
Apr 28, 2019
|
please leave 👍 to fast track |
cjihrig
approved these changes
Apr 28, 2019
antsmartian
approved these changes
Apr 29, 2019
Trott
approved these changes
Apr 29, 2019
|
Landed in 095bd56 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2019
PR-URL: nodejs#27459 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
PR-URL: #27459 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add mustCall to test-net-after-close test