Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented May 14, 2019

Jeremy confirmed in email that it would be OK to move them to Emeritus
status.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Jeremy confirmed in email that it would be OK to move them to Emeritus
status.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 14, 2019
@Trott Trott requested a review from whitlockjc May 14, 2019 21:58
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 17, 2019
Jeremy confirmed in email that it would be OK to move them to Emeritus
status.

PR-URL: nodejs#27702
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 17, 2019

Landed in c5049d4

@Trott Trott closed this May 17, 2019
targos pushed a commit that referenced this pull request May 17, 2019
Jeremy confirmed in email that it would be OK to move them to Emeritus
status.

PR-URL: #27702
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
@Trott Trott deleted the jwhitlock2emeritus branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants