Skip to content

http: symbol naming convention #29091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

http: symbol naming convention #29091

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 12, 2019

Follow the naming convention for symbols.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 12, 2019
@ronag ronag mentioned this pull request Aug 12, 2019
Closed
4 tasks
legendecas
legendecas reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any written rules for naming a variable of various types?

@ronag
Copy link
Member Author

ronag commented Aug 12, 2019 •
edited
Loading

@legendecas: Not that I'm aware of. But it's the convention used in the rest of the code.

@ronag ronag force-pushed the http-out-headers-key branch 5 times, most recently from 566f9aa to 945b126 Compare August 12, 2019 08:25
@ronag
Copy link
Member Author

ronag commented Aug 12, 2019

@Trott: flaky test?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24947/

lpinca
lpinca approved these changes Aug 12, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24950/

@ronag ronag force-pushed the http-out-headers-key branch from 945b126 to 0bdebc9 Compare August 12, 2019 19:12
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24954/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24956/

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 14, 2019
@ronag @Trott
http: follow symbol naming convention
d303548 
PR-URL: nodejs#29091
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 14, 2019

Landed in d303548

@Trott Trott closed this Aug 14, 2019
targos pushed a commit that referenced this pull request Aug 19, 2019
@ronag @targos
http: follow symbol naming convention
6b9e372 
PR-URL: #29091
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
This was referenced Aug 20, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag @nodejs-github-bot @Trott @jasnell @addaleax @lpinca @legendecas