Skip to content

Conversation

@andrewhughes101
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

cc @BethGriggs

Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: nodejs#26990
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 16, 2019
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 16, 2019
@targos
Copy link
Member

targos commented Aug 16, 2019

👍 to fast-track

@targos
Copy link
Member

targos commented Aug 16, 2019

The link is also missing in https://github.com/nodejs/node/blob/master/CHANGELOG.md

No it's not

@BethGriggs
Copy link
Member

BethGriggs pushed a commit that referenced this pull request Aug 16, 2019
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs
Copy link
Member

Landed in 791409a

Thank you for your contribution 🎉

@BethGriggs BethGriggs closed this Aug 16, 2019
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants