http2: replace var with let/const #30417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
the
code-and-learn
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
jasnell
reviewed
Nov 12, 2019
Co-Authored-By: James M Snell <[email protected]>
jasnell
reviewed
Nov 12, 2019
Co-Authored-By: James M Snell <[email protected]>
jasnell
approved these changes
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
gireeshpunathil
approved these changes
Nov 16, 2019
Trott
pushed a commit
that referenced
this pull request
Nov 23, 2019
PR-URL: #30417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 0271f1b. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30417 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed var to let and const on util. Keeping var on for loops.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes