Skip to content

src: make debug_options getters public #30494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

src: make debug_options getters public #30494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/node_options-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ PerIsolateOptions* PerProcessOptions::get_per_isolate_options() {
return per_isolate.get();
}

DebugOptions* EnvironmentOptions::get_debug_options() {
return &debug_options_;
}

const DebugOptions& EnvironmentOptions::debug_options() const {
return debug_options_;
}

EnvironmentOptions* PerIsolateOptions::get_per_env_options() {
return per_env.get();
}
Expand Down
5 changes: 3 additions & 2 deletions src/node_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,9 @@ class EnvironmentOptions : public Options {

std::vector<std::string> user_argv;

inline DebugOptions* get_debug_options();
inline const DebugOptions& debug_options() const;
inline DebugOptions* get_debug_options() { return &debug_options_; }
inline const DebugOptions& debug_options() const { return debug_options_; }

void CheckOptions(std::vector<std::string>* errors) override;

private:
Expand Down