src: use uv_async_t for WeakRefs #30616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to nodejs#30198
nodejs-github-bot
added
the
c++
devsnek
approved these changes
Nov 23, 2019
Collaborator
bnoordhuis
approved these changes
Nov 25, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
PR itself LGTM but the test fails on the Windows bots. The ICE on the ARM buildbot appears to be an OOM.
Collaborator
Collaborator
addaleax
added
the
author ready
Member
Author
|
Landed in fad952a |
addaleax
added a commit
that referenced
this pull request
Nov 29, 2019
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax
added a commit
that referenced
this pull request
Nov 29, 2019
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule a task on the main event loop, similar to what the HTML
spec recommends for browsers.
Alternative to #30198
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes