v10.18.1 proposal #30796
Closed
v10.18.1 proposal #30796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #30338 PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Refs: #30211 Refs: #30356 PR-URL: #30479 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Original commit message:
[Intl] Fix output of hour:'2-digit', hour12: true
Bug: chromium:527926
Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
Reviewed-by: Sathya Gunasekaran <[email protected]>
Commit-Queue: Frank Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#60379}
Refs: v8/v8@fb63e5c
Fixes: #30369
Backport-PR-URL: #30372
napi_get_last_error returns incorrect napi_status. Backport-PR-URL: #30532 PR-URL: #28702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
nodejs-github-bot
added
lib / src
|
@BethGriggs I'd like to see if we can include #30684 fwiw it lands cleanly, just unsure about timing |
The ability to pause input processing was added in 8a4a193 but introduced a session memory accounting mismatch leading to potential NGHTTP2_ENHANCE_YOUR_CALM errors. After pausing (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871), the early return on line 873 skips the DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878). When we later finished processing the input chunk (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858), we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line 1875] which was a no-op since we just set stream_buf_offset_ to 0 [line 1873]. The correct amount to decrement by is still stream_buf_.len, since that's the amount we skipped previously (line 878). Fixes: #29223 Refs: 164ac5b PR-URL: #30684 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Notable changes: - TBD PR-URL: #30796
BethGriggs
force-pushed
the
v10.17.1-proposal
branch
from
135594d to
7b72862
Compare
|
@MylesBorins added #30684 and updated the proposal |
|
I imagine this should include d8fc0ae. |
Sounds like the npm update will be going out in a security release: nodejs/nodejs.org#2822 |
4 tasks
Merged
|
Closing in favour of #31248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft proposal - please let me know which other PRs should be included (or tag them with the
lts-watch-v10.xlabel) and I will try and get them landed.There are currently 93 PRs tagged
backport-requested-v10.x. I'll try and work through some of these over the next few days, but help would be appreciated.@nodejs/releasers / @nodejs/backporters feel free to push any additional commits to
v10.x-stagingand I'll rebase the proposal. If we get a large number of additional changes we should consider pushing the release date out by a week to 2019-12-17 to allow adequate time for the RC phase.TBD, Version 10.17.1 'Dubnium' (LTS), @BethGriggs
Notable changes
Commits
61d6ac7f05] - build: fix configure script to work with Apple Clang 11 (Saagar Jha) #280714d3ec1a43e] - build,win: propagate error codes in vcbuild (João Reis) #30724c3e386284e] - build,win: add test-ci-native and test-ci-js (João Reis) #307240a7f6fa6b8] - deps: V8: backport fb63e5cf55e9 (Michaël Zasso)8e0ea6ddc4] - http2: use the latest settings (ZYSzys) #29780efeac48ee7] - lib: fix comment nits in bootstrap\loaders.js (Vse Mozhet Byt) #2464114e7a35e95] - n-api: correct bug in napi_get_last_error (Octavian Soldea) #28702c4dc53c479] - stream: extract Readable.from in its own file (Matteo Collina) #30140fabbc76928] - test: do not fail SLOW tests if they are not slow (Yang Guo) #25868501ebbbcf4] - tools: update tzdata to 2019c (Myles Borins) #304797ff19bec50] - tools: move python code out of jenkins shell (Sam Roberts) #284587066335cf0] - tools: fix v8 testing with devtoolset on ppcle (Sam Roberts) #28458