[v12 backport] Modules bootstrap refactoring #31242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
Contributor
Contributor
|
Realizing I left my post only half done. I may build on top of your PR to make the new PR if you are ok with that, were there a lot of conflicts that you dealt with? |
Contributor
Author
|
@MylesBorins I'm definitely OK with that :)
It depends what you call a lot, I suppose, there were a few for sure. |
Member
|
this commit also landed cleanly after the previous ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29937.
Blocked by #31241.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes