Skip to content

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The ...transforms parameter seems optional.

Refs:

if (streams.length < 2) {
throw new ERR_MISSING_ARGS('streams');
}

Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators
(see the last example)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Feb 14, 2020
@ronag
Copy link
Member

ronag commented Feb 14, 2020

Isn't ...transform already optional by definition? i.e. ... is a sequence which may be empty.

@jasnell
Copy link
Member

jasnell commented Feb 14, 2020

Yes, but the [ .. ] bracket syntax is more idiomatic across our docs.

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Feb 14, 2020

Sorry, I did not even consider ... may mean an empty list (i.e. for me it was rather transform+ than transform*). So maybe there are some more readers like me)

@vsemozhetbyt
Copy link
Contributor Author

lpinca pushed a commit that referenced this pull request Feb 22, 2020
@lpinca
Copy link
Member

lpinca commented Feb 22, 2020

Landed in 2f23918.

@lpinca lpinca closed this Feb 22, 2020
@vsemozhetbyt vsemozhetbyt deleted the doc-stream-pipeline-signature branch February 22, 2020 10:04
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants