src: Handle NULL env scenario #31899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
reviewed
Feb 21, 2020
HarshithaKP
force-pushed
the
module_wrap_handle_null_ptr
branch
from
c06e445 to
baa5f1a
Compare
mscdex
reviewed
Feb 21, 2020
|
While going through the file found one more similar location, fixed it. |
|
Surprisingly |
addaleax
reviewed
Mar 4, 2020
HarshithaKP
force-pushed
the
module_wrap_handle_null_ptr
branch
from
870a3cb to
53c0050
Compare
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc
HarshithaKP
force-pushed
the
module_wrap_handle_null_ptr
branch
from
8594430 to
8069174
Compare
|
I rebased and commits squashed |
addaleax
approved these changes
Mar 5, 2020
addaleax
added
the
author ready
|
Landed in e9fa5ae |
addaleax
pushed a commit
that referenced
this pull request
Mar 9, 2020
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: #31899 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: #31899 Reviewed-By: Anna Henningsen <[email protected]>
Merged
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: nodejs#31899 Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: #31899 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes