- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
meta: move maclover7 to Emeritus #31994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    MylesBorins
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the hard work!
              
                    gireeshpunathil
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
              
                    mmarchini
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
              
                    BridgeAR
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Feb 28, 2020 
                  
              
              
            
            
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: nodejs#31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
| Landed in ed16746 | 
      
     Merged
  
    
  codebytere 
      pushed a commit
      that referenced
      this pull request
    
      Mar 3, 2020 
    
    
      
  
    
      
    
  
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  codebytere 
      pushed a commit
      that referenced
      this pull request
    
      Mar 15, 2020 
    
    
      
  
    
      
    
  
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
    
  codebytere 
      pushed a commit
      that referenced
      this pull request
    
      Mar 17, 2020 
    
    
      
  
    
      
    
  
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
      
     Merged
  
    
  codebytere 
      pushed a commit
      that referenced
      this pull request
    
      Mar 30, 2020 
    
    
      
  
    
      
    
  
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    doc
  Issues and PRs related to the documentations. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
In email, maclover7 confirmed that are fine to move to emeritus status.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes