http2: add bytesWritten test for Http2Stream
#33162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that this is for the `Http2Server` class. I'll soon be adding one for `Http2SecureServer` as well. Refs: nodejs#29829
jasnell
approved these changes
Apr 30, 2020
ronag
reviewed
May 1, 2020
BridgeAR
added
the
author ready
|
For whoever lands this: The commit message should start with |
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
note that this is for the `Http2Server` class. I'll soon be adding one for `Http2SecureServer` as well. Refs: #29829 PR-URL: #33162 Reviewed-By: James M Snell <[email protected]>
|
Landed in 1aa491a |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
note that this is for the `Http2Server` class. I'll soon be adding one for `Http2SecureServer` as well. Refs: #29829 PR-URL: #33162 Reviewed-By: James M Snell <[email protected]>
Merged
32 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
note that this is for the `Http2Server` class. I'll soon be adding one for `Http2SecureServer` as well. Refs: #29829 PR-URL: #33162 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #29829
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes