wasi: prevent syscalls before start #33235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
I just noticed that #33184 already exists. I guess this is still a valid alternative with a few important differences. |
3 tasks
cjihrig
approved these changes
May 4, 2020
Co-authored-by: Colin Ihrig <[email protected]>
tniessen
commented
May 4, 2020
devsnek
approved these changes
May 4, 2020
addaleax
approved these changes
May 5, 2020
addaleax
pushed a commit
that referenced
this pull request
May 7, 2020
PR-URL: #33235 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in c01544d |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
PR-URL: #33235 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33235 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
instance.exports._start()crashes the process with a segmentation fault. This prevents syscalls beforestart()has been called.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes