doc: add note about clientError writable handling #33308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Eomm
reviewed
May 8, 2020
Co-authored-by: Manuel Spigolon <[email protected]>
Trott
reviewed
May 9, 2020
Co-authored-by: Rich Trott <[email protected]>
|
@Trott are you ok for this landing? |
Yes. |
mcollina
pushed a commit
that referenced
this pull request
May 12, 2020
PR-URL: #33308 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 5bb4d01 |
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
PR-URL: #33308 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33308 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33302.
This PR add a little note about checking writable state of socket in
clientErrorbefore attempt to send data.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes