Skip to content

vm: allow proxy callbacks to throw #33808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

vm: allow proxy callbacks to throw #33808

merged 1 commit into from
Jun 11, 2020

Conversation

@devsnek
Copy link
Member

@devsnek devsnek commented Jun 9, 2020 •
edited
Loading

Fixes #33806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Jun 9, 2020
@lrlna lrlna mentioned this pull request Jun 9, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31796/

@github-actions github-actions bot mentioned this pull request Jun 10, 2020
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31832/

@devsnek
vm: allow proxy callbacks to throw
4faec56 
Fixes: nodejs#33806

PR-URL: nodejs#33808
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@devsnek devsnek merged commit 4faec56 into nodejs:master Jun 11, 2020
@devsnek devsnek deleted the fix-33806 branch June 11, 2020 14:43
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@devsnek @codebytere
vm: allow proxy callbacks to throw
879c932 
Fixes: #33806

PR-URL: #33808
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@devsnek @codebytere
vm: allow proxy callbacks to throw
3b9d9cc 
Fixes: #33806

PR-URL: #33808
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@devsnek @codebytere
vm: allow proxy callbacks to throw
c4129f9 
Fixes: #33806

PR-URL: #33808
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@devsnek @codebytere
vm: allow proxy callbacks to throw
4500bc4 
Fixes: #33806

PR-URL: #33808
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@lrlna lrlna lrlna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VM aborts when error thrown when in property setter

9 participants

@devsnek @nodejs-github-bot @jasnell @addaleax @targos @cjihrig @lrlna @Flarna @MylesBorins