events: fix add-remove-add case in EventTarget #34056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that listeners are added properly if there has previously been one but currently are none for a given event type.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32093/ (:yellow_heart:) |
addaleax
added
the
eventtarget
|
fast-track? |
jasnell
approved these changes
Jun 25, 2020
4 tasks
Trott
approved these changes
Jun 26, 2020
|
Landed in e18afe4 |
Trott
pushed a commit
that referenced
this pull request
Jun 26, 2020
Make sure that listeners are added properly if there has previously been one but currently are none for a given event type. PR-URL: #34056 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Make sure that listeners are added properly if there has previously been one but currently are none for a given event type. PR-URL: #34056 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Make sure that listeners are added properly if there has previously been one but currently are none for a given event type. PR-URL: #34056 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that listeners are added properly if there has previously
been one but currently are none for a given event type.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes