http: fixed invalid path with connect method #34408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
requested changes
Jul 17, 2020
| req.emit('error', err); | ||
| } | ||
| req._closed = true; | ||
| req[kClosed] = true; |
There was a problem hiding this comment.
This is not ok, see discussion on #34313.
There was a problem hiding this comment.
This seems strange, I can't remember changing this part of the file however I will revert the changes for now and create another PR.
|
Also this needs tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34347
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes