Skip to content

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: guard against nullptr deref in TimerWrapHandle::Stop #34460

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #34454

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jul 21, 2020
@addaleax addaleax mentioned this pull request Jul 21, 2020
Closed
4 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32442/ (:green_heart:)

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2020
@jasnell
Copy link
Member

jasnell commented Jul 21, 2020

Fast-track? Please 👍🏻

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020
@addaleax
Copy link
Member Author

Landed in feb93c4

@addaleax addaleax closed this Jul 21, 2020
addaleax added a commit that referenced this pull request Jul 21, 2020
@addaleax
src: guard against nullptr deref in TimerWrapHandle::Stop
feb93c4 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@addaleax addaleax deleted the timer-wrap-nullptr-deref branch July 21, 2020 19:11
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@addaleax @cjihrig
src: guard against nullptr deref in TimerWrapHandle::Stop
fe69e1e 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@ruyadorno
Copy link
Member

This does not land cleanly on v14.x 🤔 should it be backported ?

@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
@addaleax @targos
src: guard against nullptr deref in TimerWrapHandle::Stop
b1d5160 
Refs: #34454

PR-URL: #34460
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
This was referenced May 22, 2023
Open
Open
Open
@137717unity 137717unity mentioned this pull request May 22, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request May 24, 2023
Open
@baby636 baby636 mentioned this pull request May 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 19, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 19, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 19, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 19, 2023
Open
@baby636 baby636 mentioned this pull request Dec 20, 2023
Open
@137717unity 137717unity mentioned this pull request Apr 14, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 14, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 14, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Apr 14, 2024
Open
@kissofire kissofire mentioned this pull request Apr 14, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 14, 2024
Open
@baby636 baby636 mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax @nodejs-github-bot @jasnell @ruyadorno @gengjiawen @devnexen @richardlau @targos