test: harden test-child-process-fork-regr-gh-2847 #3459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-child-process-fork-regr-nodejsgh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully submitting on behalf of gireeshpunathil as he is out on vacation this week
mscdex
added
child_process
|
LGTM |
|
@mhdawson ... there are some CI failures but they don't look relevant to this change. Can you take a look and verify? |
|
Agreed don't think any of those failures are related to this PR. |
mhdawson
added a commit
that referenced
this pull request
Oct 21, 2015
test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <[email protected]> PR-URL: #3459
|
Landed in e9e837c |
mhdawson
added a commit
to ibmruntimes/node
that referenced
this pull request
Oct 21, 2015
test-child-process-fork-regr-nodejsgh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs/node#3459
mhdawson
added a commit
that referenced
this pull request
Oct 22, 2015
test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <[email protected]> PR-URL: #3459
|
@mhdawson for future reference, can you add |
mhdawson
added a commit
that referenced
this pull request
Oct 26, 2015
test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <[email protected]> PR-URL: #3459
|
Landed in v4.x-staging in 304eda4 |
This was referenced Oct 27, 2015
mhdawson
added a commit
that referenced
this pull request
Oct 29, 2015
test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <[email protected]> PR-URL: #3459
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur. This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully
submitting on behalf of gireeshpunathil as he is out on
vacation this week. See discussion in #3245
in respect to detailed investigation of test behaviour