readline: fix key name for function keys combined with modifiers #35268
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
readline
addaleax
approved these changes
Sep 20, 2020
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Sep 20, 2020
Trott
approved these changes
Sep 21, 2020
Fixes: nodejs#35251 PR-URL: nodejs#35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
fix-emitted-key-name
branch
from
4002565 to
17ebd46
Compare
|
Landed in 17ebd46 |
|
Thanks for the contribution! 🎉 |
|
@Trott @addaleax @joyeecheung PS: I didn't want to open an new issue just for this, I'm not even sure if it's really an issue. |
|
@DrunkenPoney That doesn’t sound intentional to me, no. Feel free to fix this if you like 👍 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 21, 2020
Fixes: #35251 PR-URL: #35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Fixes: nodejs#35251 PR-URL: nodejs#35268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proper key names for function key (e.g. F4) combined with modifiers (e.g. Ctrl).
I also added support for:
Fixes #35251
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes