[v14.x backport] http2: check write not scheduled in scope destructor #36372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36372 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/34884/ |
|
Last CI is good (osx failure appears to be due to nodejs/build#2482). The original PR #36241 hasn't been in current for 2 weeks - could anyone from @nodejs/http2 give this a review and advise whether you feel it should land in v14.x without the wait? |
|
I would include it. |
BethGriggs
force-pushed
the
v14.x-staging
branch
from
3168ac1 to
c44b478
Compare
BethGriggs
approved these changes
Dec 10, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36372 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 4b315a5 |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36372 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33156
PR-URL: #36241
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Rich Trott [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes