lib: add primordials.SafeStringIterator #36526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
readline
|
I found some code, seems they should be submitted together with this PR. node/lib/internal/util/inspect.js Line 2008 in 6837a6d |
aduh95
force-pushed
the
safe-string-iterable
branch
from
e69e07a to
d1ae5c5
Compare
|
@Lxxyx Good catch! I added your suggestions. |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
Benchmark CI (util/inspect): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/797/ (queued) |
Trott
approved these changes
Dec 25, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 40fc395...bd6f230 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
PR-URL: #36526 Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows node internal function to iterate over strings without relying on
String.prototype[Symbol.iterator]and%StringIteratorPrototype%.next, which may be mutated from user-land.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes