doc: correct callback parameter type for createPushResponse() #36631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
/ping @ericrannaud |
benjamingr
approved these changes
Dec 25, 2020
lpinca
approved these changes
Dec 25, 2020
Refs: nodejs#22322 (comment) PR-URL: nodejs#36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
All the properties are already in alphabetical order except for createPushResponse(). Move that property to the alphabetical location in the list. PR-URL: nodejs#36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 245159f...0878d4d |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Refs: #22322 (comment) PR-URL: #36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
All the properties are already in alphabetical order except for createPushResponse(). Move that property to the alphabetical location in the list. PR-URL: #36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: #22322 (comment) PR-URL: #36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
All the properties are already in alphabetical order except for createPushResponse(). Move that property to the alphabetical location in the list. PR-URL: #36631 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #22322 (comment)
Also: All the properties are already in alphabetical order except for createPushResponse(). Move that property to the alphabetical location in the list.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes