stream: do not use _stream_* anymore #36684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all leftover usage of _stream_* and keep all of them as legacy. We do not deprecate the old modules to avoid disrupition and ease maintainance.
nodejs-github-bot
added
the
lib / src
4 tasks
ronag
approved these changes
Dec 30, 2020
addaleax
approved these changes
Dec 30, 2020
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Jan 2, 2021
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
mcollina
added a commit
that referenced
this pull request
Jan 5, 2021
Remove all leftover usage of _stream_* and keep all of them as legacy. We do not deprecate the old modules to avoid disrupition and ease maintainance. PR-URL: #36684 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Author
|
Landed in f8b9831 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Remove all leftover usage of _stream_* and keep all of them as legacy. We do not deprecate the old modules to avoid disrupition and ease maintainance. PR-URL: #36684 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all leftover usage of
_stream_*and keep all of them as legacy.We do not deprecate the old modules to avoid disrupition and ease
maintainance.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes