doc: avoid memory leak warning in async_hooks example #36783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Flarna
approved these changes
Jan 4, 2021
juanarbol
approved these changes
Jan 5, 2021
jasnell
added
author ready
|
This shouldn't need to wait the full time to land. Please 👍🏻 to fast track |
Flarna
added
the
commit-queue
jasnell
removed
the
commit-queue
|
Landed in 3518919 |
jasnell
added a commit
that referenced
this pull request
Jan 6, 2021
Fixes: #35952 PR-URL: #36783 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Fixes: #35952 PR-URL: #36783 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fixes: #35952 PR-URL: #36783 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example lead to an event emitter memory leak warning previously.
Fixes: #35952
Signed-off-by: James M Snell [email protected]