Skip to content

Conversation

@guybedford
Copy link
Contributor

This updates the documentation of the resolver specification to include the Unsupported Directory Import in ths list of errors provided at the top of the specification, to ensure this list remains exhaustive of all the errors that might be thrown by the resolver.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 23, 2021
@guybedford
Copy link
Contributor Author

@nodejs/modules

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with spelling fix.

Co-authored-by: Rich Trott <[email protected]>
guybedford added a commit that referenced this pull request Jan 25, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in efa6e1d.

@guybedford guybedford closed this Jan 25, 2021
@guybedford guybedford deleted the list-unsupported-dir-import branch January 25, 2021 11:05
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants