test: improve assertion message for test-vm-memleak #37034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
flaky-test
gireeshpunathil
approved these changes
Jan 23, 2021
aduh95
approved these changes
Jan 23, 2021
lpinca
approved these changes
Jan 23, 2021
Trott
added
request-ci
The test is unreliable in CI. It might be helpful to get an exact read of `rss` so this adds that to the assertion message. PR-URL: nodejs#37034 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 13ac5fb |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
The test is unreliable in CI. It might be helpful to get an exact read of `rss` so this adds that to the assertion message. PR-URL: #37034 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The test is unreliable in CI. It might be helpful to get an exact read of `rss` so this adds that to the assertion message. PR-URL: #37034 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is unreliable in CI. It might be helpful to get an exact read
of
rssso this adds that to the assertion message.