doc: apply sentence case to release doc headers #37349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
approved these changes
Feb 13, 2021
|
In the commit message:
I guess, this could also be addressed while landing this. |
Trott
force-pushed
the
release-sentence
branch
from
437b340 to
ba2c4f5
Compare
Fixed those and also propagated the capitalization changes to the table of contents. Thanks! |
Trott
changed the title
Trott
force-pushed
the
release-sentence
branch
from
ba2c4f5 to
14f8b2d
Compare
targos
approved these changes
Feb 13, 2021
lpinca
approved these changes
Feb 13, 2021
marsonya
approved these changes
Feb 14, 2021
jasnell
approved these changes
Feb 14, 2021
|
Landed in dd731e2 |
Trott
force-pushed
the
release-sentence
branch
from
14f8b2d to
dd731e2
Compare
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Our style is to use sentence case for headers and documentation titles. The documentation for releases uses both sentence case and title case. This change applies sentence case consistently throughout. PR-URL: #37349 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Our style is to use sentence case for headers and documentation titles. The documentation for releases uses both sentence case and title case. This change applies sentence case consistently throughout. PR-URL: #37349 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our style is to use sentence case for headers and documentation titles.
The documentation for releases uses both sentence case and title case.
This change applies sentence case consistently throughout.