path: fix posix.relative() on Windows #37747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The change to test-path-resolve is, in my opinion, a bugfix and not a semver-major change. In all other cases, calling path.posix.resolve() returns a POSIX-y path. In these two (really one) edge cases in the test, it results in a Windows-y path on Windows and a POSIX-y path elsewhere. I think path.posix.resolve() should always return a POSIX-y path and the fact that it doesn't in some cases is surprising and a bug. |
|
@nodejs/path @nodejs/platform-windows |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
reviewed
Mar 14, 2021
This comment has been minimized.
This comment has been minimized.
|
@nodejs/path @nodejs/platform-windows @nodejs/tsc This could use some reviews. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Mar 19, 2021
This comment has been minimized.
This comment has been minimized.
|
@mcollina I believe your request for changes has been addressed. Can you take a look? |
Fixes: nodejs#13683 PR-URL: nodejs#37747 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in b0d5e03 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
Fixes: #13683 PR-URL: #37747 Reviewed-By: Matteo Collina <[email protected]>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is #37744. Second commit will be rebased to be the only commit in this PR once that other pull request lands.Fixes: #13683