Skip to content

Conversation

peZhmanParsaee
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 24, 2021
@peZhmanParsaee peZhmanParsaee changed the title fix "the the" typo in README.md of cjs-module-lexer doc: fix "the the" typo in README.md of cjs-module-lexer Mar 24, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 24, 2021

/cc @guybedford

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to be accepted upstream first (at https://github.com/guybedford/cjs-module-lexer) before it can land here.

@peZhmanParsaee peZhmanParsaee requested a review from aduh95 March 25, 2021 18:33
@peZhmanParsaee
Copy link
Contributor Author

This change needs to be accepted upstream first (at https://github.com/guybedford/cjs-module-lexer) before it can land here.

Hi @aduh95 , changes was applied on cjs-module-lexer repository. Would you reconsider your review? Tnx

@RaisinTen
Copy link
Member

@peZhmanParsaee We tend not to make changes to the parts in deps as these are updated with a PR when a new release of the dependency is available. You may check out #37712 to get an idea of how it has been done for cjs-module-lexer.

@aduh95
Copy link
Contributor

aduh95 commented Mar 26, 2021

Thanks a lot for taking the time to send the PR upstream. Guy has indicated in nodejs/cjs-module-lexer#48 (comment) that there's likely no upcoming release in the near future, so I suppose it is fine to land this here before it's officially released upstream. I'll try to take care of this early next week.

@peZhmanParsaee
Copy link
Contributor Author

@aduh95

Thanks a lot dude
Your help is much appreciated and has given much positive energy to me :)

Original commit message:
	fix "the the" typo in README.md file

Refs: nodejs/cjs-module-lexer@22093e7

PR-URL: nodejs#37895
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@aduh95 aduh95 force-pushed the doc-cjs-module-lexer-readme-typo branch from 45dc755 to d7b8638 Compare March 30, 2021 08:15
@aduh95 aduh95 merged commit d7b8638 into nodejs:master Mar 30, 2021
@aduh95
Copy link
Contributor

aduh95 commented Mar 30, 2021

Landed in d7b8638. Thanks for your contribution :)

MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
Original commit message:
	fix "the the" typo in README.md file

Refs: nodejs/cjs-module-lexer@22093e7

PR-URL: #37895
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants