readline: fix pre-aborted AbortSignal question handling #37929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix pre-aborted question handling
nodejs-github-bot
added
needs-ci
benjamingr
reviewed
Mar 26, 2021
benjamingr
approved these changes
Mar 26, 2021
Linkgoron
force-pushed
the
readline-question-pre-abort-signal
branch
from
f10ef73 to
a676afe
Compare
jasnell
approved these changes
Mar 27, 2021
marsonya
approved these changes
Mar 27, 2021
Linkgoron
added
the
author ready
jasnell
pushed a commit
that referenced
this pull request
Apr 1, 2021
fix pre-aborted question handling PR-URL: #37929 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in dbab289 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
fix pre-aborted question handling PR-URL: #37929 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
questioninreadlinewas missing pre-aborted AbortSignal handling. I'm not sure if the behaviour for the callback version is confusing or not (if the signal is already aborted, just return and do nothing) - so thoughts are welcome.