Skip to content

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Mar 31, 2021

Fixes: #37995

Uint32 should be between [0, 2 ** 32)

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Mar 31, 2021
@RaisinTen
Copy link
Member

RaisinTen commented Mar 31, 2021

I'm not sure that this is a valid fix for this issue as -1 is actually an accepted value for owner and group. This is almost like a revert of #31694 which added support for -1.

@benjamingr benjamingr mentioned this pull request Mar 31, 2021
@ycjcl868 ycjcl868 changed the title fix: valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown fs: fix valid id range on fs.chown, fs.chownSync, fs.lchown, fs.fchown Apr 1, 2021
@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Apr 1, 2021

Fix by #38004, Closed

@ycjcl868 ycjcl868 closed this Apr 1, 2021
@ycjcl868 ycjcl868 deleted the fs-chown-range branch April 1, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"fs.chownSync" results in an abort

3 participants