test: deflake test-http-many-ended-pipelines #38018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
commented
Apr 1, 2021
| client.on('error', function(err) { | ||
| // The socket might be destroyed by the other peer while data is still | ||
| // being written. | ||
| assert.strictEqual(err.code, 'ECONNRESET'); |
There was a problem hiding this comment.
I think err.code can also be 'EPIPE' or 'ECONNABORTED' but I was not able to reproduce. Should we handle that in advance or do it if/when it will occur?
There was a problem hiding this comment.
I'd say let's do it when it occurs.
There was a problem hiding this comment.
Perhaps you can add a comment right now that says "EPIPE might be valid too but we haven't seen it yet" or something like that?
Trott
approved these changes
Apr 3, 2021
The socket might be destroyed by the other peer while data is still being written. Add the missing error handler. Fixes: nodejs#37291
cjihrig
approved these changes
Apr 8, 2021
lpinca
added a commit
that referenced
this pull request
Apr 8, 2021
The socket might be destroyed by the other peer while data is still being written. Add the missing error handler. PR-URL: #38018 Fixes: #37291 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in cc4ee6c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket might be destroyed by the other peer while data is still
being written. Add the missing error handler.
Fixes: #37291