crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name #38029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/crypto |
jasnell
approved these changes
Apr 1, 2021
panva
added
author ready
|
@jasnell what am i missing here? why are the string changes not enough? Edit: I see now: |
panva
force-pushed
the
fix-rsa1_5-algorithm
branch
from
d4aebbb to
0f03843
Compare
jasnell
approved these changes
Apr 2, 2021
panva
added a commit
that referenced
this pull request
Apr 3, 2021
PR-URL: #38029 Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in c81d0fa |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
PR-URL: #38029 Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2021
PR-URL: #38029 Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the algorithm name used in Web Cryptography API.
Correct value is
RSASSA-PKCS1-v1_5. The difference is lowercase "v" instead of uppercase "V".Ref: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1